-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Groups and Namespaces based authorization, for Users and Service Accounts #5619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
franciscojavierarceo
merged 7 commits into
feast-dev:master
from
jyejare:groups_nss_roles
Oct 10, 2025
Merged
feat: Groups and Namespaces based authorization, for Users and Service Accounts #5619
franciscojavierarceo
merged 7 commits into
feast-dev:master
from
jyejare:groups_nss_roles
Oct 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b9f9fc
to
2b8e653
Compare
3e90d71
to
9c913b9
Compare
0d9e32e
to
61704dd
Compare
Signed-off-by: jyejare <[email protected]>
…namespace Signed-off-by: jyejare <[email protected]>
61704dd
to
95f6489
Compare
Signed-off-by: jyejare <[email protected]>
Signed-off-by: jyejare <[email protected]>
Signed-off-by: jyejare <[email protected]>
95f6489
to
65ca1b1
Compare
ntkathole
reviewed
Oct 9, 2025
ntkathole
reviewed
Oct 9, 2025
ntkathole
reviewed
Oct 9, 2025
ntkathole
reviewed
Oct 9, 2025
ntkathole
reviewed
Oct 9, 2025
Signed-off-by: jyejare <[email protected]>
22880e7
to
fa12ca7
Compare
ntkathole
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thank you @jyejare . This is nice improvement to kubernetes authentication.
franciscojavierarceo
pushed a commit
that referenced
this pull request
Oct 14, 2025
# [0.55.0](v0.54.0...v0.55.0) (2025-10-14) ### Bug Fixes * Added unix_timestamp_val in _serialize_val ([#5659](#5659)) ([35a8423](35a8423)) * BatchFeatureView transformation should persist in Registry Ser/Deserialization ([3364bad](3364bad)) * Check if DynamoDB table exists before create ([#5658](#5658)) ([e7fd506](e7fd506)) * Fix the link to Expedia in the Go Feature Server readme. ([3ed0163](3ed0163)) ### Features * Add Claude instructions ([#5651](#5651)) ([4807a52](4807a52)) * Groups and Namespaces based authorization, for Users and Service Accounts ([#5619](#5619)) ([da6257c](da6257c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Groups and Namespaces Based Authorization support
Overview
This PR implements groups and namespaces extraction support in Feast for user authentication (along with existing service account) in Pull Request #5619.
Changes Made
1. Enhanced User Model (
sdk/python/feast/permissions/user.py
)groups
andnamespaces
attributeshas_matching_group()
: Check if user has required groupshas_matching_namespace()
: Check if user has required namespaces2. New Policy Types (
sdk/python/feast/permissions/policy.py
)3. Protobuf Definitions (
protos/feast/core/Policy.proto
)make compile-protos-python
4. Token Access Review Integration (
sdk/python/feast/permissions/auth/kubernetes_token_parser.py
)_extract_groups_and_namespaces_from_token()
:user_details_from_access_token()
to include groups and namespaces5. Client SDK Updates (
sdk/python/feast/permissions/client/kubernetes_auth_client_manager.py
)get_token()
method to check for user_token in config6. Configuration Model (
sdk/python/feast/permissions/auth_model.py
)7. Comprehensive Tests (
sdk/python/tests/permissions/test_groups_namespaces_auth.py
)8. Documentation (
docs/getting-started/components/groups_namespaces_auth.md
)Key Features Implemented
✅ Token Access Review Integration
✅ Groups and Namespaces Extraction
✅ New Policy Types
✅ Client SDK Support
Usage Examples
Basic Group-Based Permission
Basic Namespace-Based Permission
Combined Group + Namespace Permission
Client Configuration with User Token